[libc++][chrono] Adds a missing main include. #132100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
the
libc++
Member
|
@llvm/pr-subscribers-libcxx Author: Mark de Wever (mordante) ChangesFull diff: https://github.com/llvm/llvm-project/pull/132100.diff 1 Files Affected:
diff --git a/libcxx/include/chrono b/libcxx/include/chrono
index d8006720c495c..a3367f89ee11d 100644
--- a/libcxx/include/chrono
+++ b/libcxx/include/chrono
@@ -1073,6 +1073,7 @@ constexpr chrono::year operator ""y(unsigned lo
# if _LIBCPP_HAS_TIME_ZONE_DATABASE && _LIBCPP_HAS_FILESYSTEM && _LIBCPP_HAS_LOCALIZATION
# include <__chrono/leap_second.h>
+# include <__chrono/gps_clock.h>
# include <__chrono/tai_clock.h>
# include <__chrono/time_zone.h>
# include <__chrono/time_zone_link.h>
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
ldionne
approved these changes
Mar 19, 2025
Member
ldionne
left a comment
ldionne
left a comment
There was a problem hiding this comment.
LGTM but I'm surprised why this wasn't caught by CI?
Member
Author
Me too. I noticed it while looking at other things. It was indirectly included by other |
frederick-vs-ja
approved these changes
Mar 20, 2025
Contributor
frederick-vs-ja
left a comment
frederick-vs-ja
left a comment
There was a problem hiding this comment.
LGTM (although formatting issue should be fixed).
mordante
force-pushed
the
review/adds_missing_include
branch
from
3189eaf to
f4c47a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.